Extract WrapsText - #6
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TextMeasurerInterfaceasks for two methods. Only one of them,measureLine(), knowsanything about the font.
wrap()is greedy line breaking that callsmeasureLine()andnothing else, so every implementation has to write it again.
atelier/diagramdid:ThemeTextMeasurerhas seven lines of its own work and 78 copiedfrom
CharWidthTextMeasurer, 76 of them character for character.This moves that logic into a
WrapsTexttrait.CharWidthTextMeasurernow uses it andkeeps only what measures a glyph.
The trait reads the baseline from
measureLine('M', ...)->ascentrather than from privatestate. Output is unchanged: lines, width, height and both baselines match to 1e-12 across
word breaking, blank text, a zero width and an overlong word.
Nothing breaks.
wrap()stays on the interface and the trait is opt-in, so an existingimplementation compiles and runs untouched.