Add metal config drive - #1
Merged
Merged
Conversation
Owner
Author
|
@copilot review this PR |
atd9876
force-pushed
the
add-metal-config-drive
branch
3 times, most recently
from
May 8, 2026 12:25
bab4a01 to
a13e77b
Compare
atd9876
force-pushed
the
add-metal-config-drive
branch
from
June 10, 2026 08:41
9a073d5 to
0861cdd
Compare
atd9876
force-pushed
the
add-metal-config-drive
branch
from
July 3, 2026 12:20
0861cdd to
06a1302
Compare
Follow the existing pattern used by SystemConfigDir and other distro functions, allowing KernelCmdlinePath to be overridden via the IGNITION_KERNEL_CMDLINE_PATH environment variable. This enables blackbox tests to inject a fake kernel cmdline. Signed-off-by: Andrew Dodds <andrew.dodds@sap.com>
Add support for loading Ignition config from a labeled block device via the ignition.config.device and ignition.config.path kernel command-line arguments. Both must be specified together. Error handling: - Return hard error if only one of device/path is specified - Return hard error if the device does not appear within 30s timeout - Return hard error if the config file is not found on the device Includes unit tests for parseCmdline and blackbox integration tests covering both positive (successful fetch) and negative (missing device, missing file, incomplete options) scenarios. Signed-off-by: Andrew Dodds <andrew.dodds@sap.com>
atd9876
force-pushed
the
add-metal-config-drive
branch
from
July 7, 2026 08:38
06a1302 to
feb4f08
Compare
If the block device is unresponsive, mount could hang indefinitely. Use exec.CommandContext so the mount is cancelled when the 30s context expires, preventing an indefinite hang. Signed-off-by: Andrew Dodds <andrew.dodds@sap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Local PR for copilot review