Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nested
patternPropertiesvalidators can reference regex or format helpers from their child schemas. The runtime compiler constructed those children withnew Function, which discarded the helper scope and caused aReferenceError.The fix - child checks execute inside the parent validator
The generated child checks now remain inside the parent validator. They can use the same regex, set, and format helper bindings as other generated checks.
This behavior also applies to an
additionalPropertiesschema when the compiler combines it withpatternProperties.Validation - runtime and schema suites pass
The regression test covers helper bindings in both generated child paths.
Ran
npm test. The complete test command passed.Ran
npm run test:suite. All 3,365 official cases passed.Ran
npm run release:check. All release checks passed.