fix: add timeout, HEAD method, and meaningful errors to registryValidation#2109
Open
TeapoyY wants to merge 1 commit intoasyncapi:masterfrom
Open
fix: add timeout, HEAD method, and meaningful errors to registryValidation#2109TeapoyY wants to merge 1 commit intoasyncapi:masterfrom
TeapoyY wants to merge 1 commit intoasyncapi:masterfrom
Conversation
…ation - Add 5-second AbortController timeout to prevent indefinite hangs - Use HEAD instead of GET for lighter-weight validation - Include original error message in thrown error for better debugging - Handle AbortError specifically with clear timeout message Fixes asyncapi#2027
TeapoyY
requested review from
AayushSaini101,
Amzani,
Shurtu-gal,
Souvikns and
asyncapi-bot-eve
as code owners
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a 5-second timeout to the registry URL validation to prevent the CLI from hanging indefinitely when the registry URL is unreachable.
Changes
--registry-urlpoints to an unreachable host (no timeout handling) #2027Testing
Run: asyncapi generate fromTemplate asyncapi.yaml @asyncapi/html-template --registry-url http://10.255.255.1
CLI should fail within 5 seconds with a meaningful error instead of hanging indefinitely.