Skip to content

Revert "Drag n Drop Photos - Staff Dashboard"#1095

Merged
ARtheboss merged 1 commit intomainfrom
revert-1094-nathan/enhancement/drag-and-drop-photo
Mar 12, 2026
Merged

Revert "Drag n Drop Photos - Staff Dashboard"#1095
ARtheboss merged 1 commit intomainfrom
revert-1094-nathan/enhancement/drag-and-drop-photo

Conversation

@NathanDai5287
Copy link
Copy Markdown
Contributor

Reverts #1094

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ab25a5b8a0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +217 to +218
img.onload = async () => {
// Crop to square from center
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Handle image load errors in photo upload flow

This change removes the previous img.onerror/file-type guard path, so when a selected file cannot be decoded as an image (e.g., corrupted image data or a mislabeled file), the handler never reaches upload/error UI and the user gets no feedback while the modal remains in an inconsistent state. The prior implementation rejected this case and surfaced an actionable error, so this is a regression in the upload flow.

Useful? React with 👍 / 👎.

@PineND
Copy link
Copy Markdown
Member

PineND commented Mar 5, 2026

Bad change to add and then revert something. Discourage this

@ARtheboss ARtheboss merged commit 50d5dfa into main Mar 12, 2026
1 check passed
@ARtheboss ARtheboss deleted the revert-1094-nathan/enhancement/drag-and-drop-photo branch March 12, 2026 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants