Fixes to reproject dispatcher#618
Merged
Merged
Conversation
…aps, since views keep the parent's unadjusted offset and were silently reprojected from the wrong file region, and pass views by reference instead
…_blocks call so edge blocks are reprojected at their true size instead of being computed at the full block size and truncated, which also avoids an irregular trailing chunk in dask results
…when dask_method='none' instead of a sentinel string resolved from the block function's closure, which embedded the whole input graph in the function's serialized state
…sions that are neither 1 nor the full extent instead of silently reinterpreting them as one slice per block
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #618 +/- ##
=======================================
Coverage 90.00% 90.00%
=======================================
Files 51 51
Lines 2311 2312 +1
=======================================
+ Hits 2080 2081 +1
Misses 231 231 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a few issues/corner cases in the reproject dispatcher