ENH: Change tapregext code to handle proposed use of forMode to allow specifying limits per mode#757
ENH: Change tapregext code to handle proposed use of forMode to allow specifying limits per mode#757stvoutsin wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #757 +/- ##
==========================================
+ Coverage 79.79% 79.93% +0.13%
==========================================
Files 91 91
Lines 10297 10424 +127
==========================================
+ Hits 8217 8332 +115
- Misses 2080 2092 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ifying limits per mode
|
On Tue, May 26, 2026 at 10:55:37AM -0700, stvoutsin wrote:
Since this is still a PR in `TAPRegExt` I'll leave this as a Draft
Oh dang, sorry I've let this slip.
I've closed ivoa-std/TAPRegExt#8, and I'm pretty sure
ivoa-std/TAPRegExt#10 is basically fine for merging. Would someone
review it?
Once it's in, I'd say we should just merge this. Ok, it's not in a
REC yet, but then I'm rather sure nothing much will break if we do
minor adjustments later, and we should really get the ball rolling
properly.
|
Oh no problem, I had also forgotten about this one until now. I've added a couple of very minor comments to that TAPRegExt PR but as far as I'm concerned it looks ready to merge. |
Description
This is my attempt to provide client support for the proposal to add a
forModeattribute to capabilities to allow specifying mode-specific (syncvsasync) limits (executionDuration,retentionPeriod,outputLimit, anduploadLimit) as written in ivoa-std/TAPRegExt#10.The current behaviour is that PyvVO will warn if more than 1 of these elements appears, which makes sense for the existing TAPRegExt spec.
Since this is still a PR in
TAPRegExtI'll leave this as a Draft PR mainly for visibility and discussion. If we don't want this cluttering the PR list I could also move this into an issue and add a comment to refer to the branch with the changes.Changes
Limit elements (
executionDuration,outputLimitetc.) are now parsed into lists with newget_x(mode)methods for mode-aware getters.One place I noticed that can take advantage of these mode-specific limits is the
run_asynctimeout, so I've changed that to default to the service's advertised async execution duration as its wait timeout.Compatibility
With the approach I've gone with existing code that depends on the singular limit properties (maxrec, and hardlimit) should be fine.