Repository navigation
chore(tooling): an accepted warning raised to an error is not "resolved" (template#101) - #54
Merged
Merged
Conversation
…ed" (template#101) Byte-identical copy of the template-owned files from adaptive-learner-content-template#104: the engine runner prints the engine's rename table and errors with their rule ID, quality_state.py follows an accepted record to a raised rule, and the warnings summary also runs after a failed gate. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Template wave for astrapi69/adaptive-learner-content-template#101 (merged as #104). Four template-owned files, byte-identical to the template's main:
scripts/quality_state.py,scripts/validate_with_engine.mjs,tests/test_quality_state.py,.github/workflows/engine-validate.yml.RENAMED W-X -> E-X, fromRENAMED_RULE_IDSandcurrentRuleId) with--warnings, and errors with their rule ID.quality_state.pyfollows an accepted record to a rule the engine raised to an error and reports the raise instead of "resolved";acceptrefuses an error.Checked locally before the PR: pin 0.40.0,
tests/test_quality_state.py25 passed, runner exit 0 (80 warning(s)), and the warnings summary of the old and newquality_state.pyon this repository's runner output is byte-identical. This repository has no accepted warnings, so its summary does not change.🤖 Generated with Claude Code