[ty] Avoid order-dependent inference for guarded attributes - #27550
Draft
charliermarsh wants to merge 17 commits into
Draft
[ty] Avoid order-dependent inference for guarded attributes#27550charliermarsh wants to merge 17 commits into
charliermarsh wants to merge 17 commits into
Conversation
This reverts commit 3ed69c2.
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 96.96%. The percentage of expected errors that received a diagnostic held steady at 92.96%. The number of fully passing files held steady at 106/133. |
Memory usage reportMemory usage unchanged ✅ |
|
| Lint rule | Added | Removed | Changed |
|---|---|---|---|
unused-type-ignore-comment |
0 | 2 | 0 |
unresolved-attribute |
0 | 1 | 0 |
| Total | 0 | 3 | 0 |
Flaky changes detected. This PR summary excludes flaky changes; see the HTML report for details.
Raw diff:
websockets (https://github.com/aaugustin/websockets)
- src/websockets/trio/client.py:543:50 error[unresolved-attribute] Object of type `Self@__aenter__` has no attribute `nursery`
werkzeug (https://github.com/pallets/werkzeug)
- src/werkzeug/debug/__init__.py:315:55 warning[unused-type-ignore-comment] Unused blanket `type: ignore` directive
- src/werkzeug/debug/__init__.py:331:55 warning[unused-type-ignore-comment] Unused blanket `type: ignore` directive
charliermarsh
force-pushed
the
charlie/fix-present-key-todos
branch
from
August 6, 2026 17:29
71eb809 to
8b42130
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We infer implicit instance attributes from assignments such as:
A negative
hasattrguard normally narrowsselftoSelf & ~Protocol[x]. When the same guard initializesx, simplifying that type requires resolvingxagain, creating a Salsa cycle whose recovered result depends on file-checking order rather than constraint-set ordering.Avoid the cycle by leaving
selfunnarrowed only when existing use-def reachability proves that the same standalone guard initializes the same implicit instance attribute in the corresponding branch. Preserve normal narrowing for class-backed attributes, previously initialized attributes, compound conditions, and assignments in the opposite branch.Stacked on #25645.
Closes astral-sh/ty#4076.