[ty] Preserve typing-only completion ranking in TYPE_CHECKING blocks - #27549
Open
AlexWaygood wants to merge 2 commits into
Open
[ty] Preserve typing-only completion ranking in TYPE_CHECKING blocks#27549AlexWaygood wants to merge 2 commits into
AlexWaygood wants to merge 2 commits into
Conversation
AlexWaygood
added
the
ty
ChatGPT Codex Connector
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Certain symbols are known not to exist at runtime (only at type-checking time), and we downrank these symbols in autocomplete suggestions in
.pyfiles. We don't need to do any such downranking when the user's cursor is inside anif TYPE_CHECKINGblock, however, information which is now easily retrievable from the semantic index. This PR updates our ranking logic to check for this before downranking type-check-only symbols.Test plan
Various scenarios in
ty_completion_evalwere updated.