Skip to content

Disallow @disjoint_base on TypedDicts and Protocols - #24671

Merged
carljm merged 1 commit into
astral-sh:mainfrom
JelleZijlstra:invalid-disjoint
Apr 16, 2026
Merged

carljm merged 1 commit into
astral-sh:mainfrom
JelleZijlstra:invalid-disjoint

Conversation

@JelleZijlstra

Copy link
Copy Markdown
Collaborator

PEP 800 calls for this but ty didn't implement this check yet. Noticed it while writing
conformance tests in python/typing#2262.

PEP 800 calls for this but ty didn't implement this check yet. Noticed it while writing
conformance tests in python/typing#2262.
@astral-sh-bot astral-sh-bot Bot added the ty The ty type checker label Apr 16, 2026
@astral-sh-bot

astral-sh-bot Bot commented Apr 16, 2026

Copy link
Copy Markdown

Typing conformance results

No changes detected ✅

Current numbers
The percentage of diagnostics emitted that were expected errors held steady at 87.94%. The percentage of expected errors that received a diagnostic held steady at 83.36%. The number of fully passing files held steady at 79/133.

@astral-sh-bot

astral-sh-bot Bot commented Apr 16, 2026

Copy link
Copy Markdown

Memory usage report

Memory usage unchanged ✅

@astral-sh-bot

astral-sh-bot Bot commented Apr 16, 2026

Copy link
Copy Markdown

ecosystem-analyzer results

No diagnostic changes detected ✅

Flaky changes detected. This PR summary excludes flaky changes; see the HTML report for details.

Full report with detailed diff (timing results)

@carljm

carljm commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

Thank you!

@carljm
carljm merged commit 9282e61 into astral-sh:main Apr 16, 2026
56 checks passed
@JelleZijlstra
JelleZijlstra deleted the invalid-disjoint branch April 16, 2026 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ty The ty type checker

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants