Merged
Conversation
Collaborator
Author
|
Very interesting, I will check it later. |
Collaborator
Author
|
There are two issues in the code transformed by KVerus:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KVerus Prompt:
You need to add the type invariant of
RWLockinostd\src\sync\rwlock.rs, which is defined in the functionclosed spec fn wf(self) -> bool.The
RwLockstructure'slockfield has the type oflock: AtomicUsize<_, Option<RwFrac<T>>,_>,, which extends the ordinary atomicusizewith a ghostRwFracpermission. TheRWFractype is an alias of typeFrac<pcell::PointsTo<T>,MAX_READER_U64>.Fracis the classical fraction permission, whose definition can be found invstd/tokens/frac.rs;pcell::PointsTois the permission to access a cell, which is defined invstd/cell/pcell.rs.You should analyze the behaviour of the
SpinLockmethods (commented in the same file), includingnew, read, write, upread, try_read, try_write, try_upread, and write the correct invariant between theAtomicaUsize's value and the ghostRwFracpermission. To learn the syntax of the invariant and how it is used, you can refer to theSpinLockinostd\src\sync\spin.rsas an example.