feat(rl): add replay-buffer persistence for interrupted training runs#809
Open
isaac-gumbrell wants to merge 5 commits into
Open
feat(rl): add replay-buffer persistence for interrupted training runs#809isaac-gumbrell wants to merge 5 commits into
isaac-gumbrell wants to merge 5 commits into
Conversation
This test imports torch, which is only installed after the first pytest run. The marker ensures the test is skipped during the initial test phase and only runs after torch is installed in the learning dependencies phase.
isaac-gumbrell
changed the title
This follows the existing RL test pattern. The try/except at module level prevents ImportError during pytest collection when torch is not installed. The importorskip inside the test provides an additional safety check to skip the test if torch becomes unavailable at runtime.
Only import torch via pytest.importorskip inside the test function. This prevents the F401 unused import error from ruff while still providing ImportError handling for pytest collection.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #809 +/- ##
==========================================
- Coverage 80.51% 80.44% -0.07%
==========================================
Files 56 56
Lines 9056 9112 +56
==========================================
+ Hits 7291 7330 +39
- Misses 1765 1782 +17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds replay-buffer persistence for reinforcement-learning runs.
The motivation is recovery from interrupted long-running training jobs. When a run crashes or is stopped partway through, reusing the replay buffer avoids recollecting the full experience set from scratch, which can significantly reduce rerun time and speed up recovery.
Changes in this PR:
Checklist
docfolder updates etc.)