Add structured validation error#745
Conversation
Signed-off-by: Jannik <raskob@fh-aachen.de>
6ee7eab to
6b1e24a
Compare
Signed-off-by: Jannik <raskob@fh-aachen.de>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #745 +/- ##
==========================================
+ Coverage 81.83% 81.85% +0.01%
==========================================
Files 55 55
Lines 8280 8288 +8
==========================================
+ Hits 6776 6784 +8
Misses 1504 1504
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| pass | ||
|
|
||
|
|
||
| class ValidationError(ValueError): |
There was a problem hiding this comment.
I would like to have every custom Exception in this File to inherit from AssumeException as well..?
You should inherit from both to not break existing catches of ValueError, but also align with the AssumeException idea.
There was a problem hiding this comment.
I still not get the idea of the Assume exception. What is its purpose (when should it be thrown)? To which use-case does this exception add value? We might use this opportunity to clarify and document this.
Signed-off-by: Jannik <raskob@fh-aachen.de>
## Description Use structured errors to identify the faulty inputs and allow the frontend to make them visible to the user ## Checklist - [x] Documentation updated (docstrings, READMEs, user guides, inline comments, `doc` folder updates etc.) - [x] Changes noted in release notes (if any) - [x] Consent to release this PR's code under the GNU Affero General Public License v3.0
Description
Use structured errors to identify the faulty inputs and allow the frontend to make them visible to the user
Checklist
docfolder updates etc.)