OUT-3261 | profile manager tags are not readable if colored#56
Merged
arpandhakal merged 2 commits intomainfrom Mar 27, 2026
Merged
OUT-3261 | profile manager tags are not readable if colored#56arpandhakal merged 2 commits intomainfrom
arpandhakal merged 2 commits intomainfrom
Conversation
Named colors (amber, cyan, teal, etc.) were used directly as chip text color, making them unreadable against the light chip background. Added a color map with dark text-safe variants and a getChipColors utility that returns proper background, border, text, and icon colors. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Replace arbitrary RGB values with exact hex values from the design system color palette. Each named color now maps to its -100 (background), -200 (border), and darkest available shade (text/icon). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
updateColor.tsgetChipColors()utility that returns proper background, border, text, and icon colors for chip stylingMultiSelectcomponent to use dark color variants for text/icons, ensuring readability against light chip backgroundsupdateColor()now also supports named colors (fixesHistoryCellRenderertoo)Test plan
updateColorwhich now handles named colors)Testing criteria
Ref
Colors picked from design system: https://www.figma.com/design/HH25FbLn13q9qx5uDCFxYI/%F0%9F%A7%A9-Design-System?node-id=115-7571&p=f&m=dev
🤖 Generated with Claude Code