Repository navigation
Conversation
Share one project-bound request snapshot across both renderers and runtime helpers, with separate controls for automatic bundle emission and hot-reload polling. Add validated application overrides, AppConfig::current(), and explicit runtime policy inspection. Remove ambient Config::set and $_ENV precedence for document defaults inside App requests. Direct View construction with omitted properties now uses application defaults; explicit ViewProperties remain authoritative. Cover snapshot ownership, development behavior, SRI emission, project isolation, malformed configuration, and lifecycle cleanup. Document the API and prepare Core 0.10.2 release notes.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applications serving verified production Web Component assets could not override automatic bundle emission and watcher polling without editing tracked
assegai.json. Separately loaded configuration could also give document scripts and runtime emission different selection values. This change makes the application's request configuration the shared owner for both rendering paths.Milestone
0.10.2
Type
Feature, bug fix, documentation, tests
Why this belongs in this milestone
Provides the supported Core configuration needed for deployments that select integrity-pinned browser assets while retaining the workspace development workflow.
What changed
webComponentsoverrides with independentenabledandhotReload.enabledswitches.AppConfig::current()andWebComponentSupport::getConfiguration()so request services can inspect the same configuration used for rendering without loading PHP fragments again.develop.What did not change
Dependency versions, workspace build configuration, and development hot reload remain compatible. Integrity attributes use the existing document script renderer.
Verification
User impact
Applications can suppress automatic bundle emission and polling through application configuration and supply verified scripts through
app.bodyScriptUrls. Omitted runtime fields inherit workspace defaults; malformed explicit overrides fail.This removes ambient
Config::set('app', ...)and$_ENV['app']precedence for document defaults inside App requests. Use application configuration or explicit render properties instead. Directnew View(...)calls with omitted properties now use configured defaults, matchingview(...); explicitViewPropertiesremain authoritative.Release notes
Included in
docs/releases/0.10.2-release-notes.md. The 0.10.2 release will be published by Andrew after merge.Upgrade notes
Included in the release notes and Web Components guide. Set both suppression flags for verified production assets, read selection through
AppConfig::current()during requests, and restart long-lived workers after deployment configuration changes.