Repository navigation
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8ec0f2bf19
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
core/src/Exceptions/Filters/LoginRedirectFilterOptions.php
Lines 37 to 40 in c7f2cbc
When authentication.loginRedirect.url is a pathless relative reference such as ?login=1 or #login, this validation accepts it, but effectiveExcludedPaths() cannot add a login path. A request to a protected /members route is therefore redirected back to /members?login=1 (or the same URL with a fragment), where the filter runs again indefinitely. Require a root-relative path for non-absolute URLs, or resolve the reference to its effective path before loop exclusion.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
LoginRedirectFilterconfig/auth.phpSession::pull()accessNo authentication interceptor is introduced or required.
Validation
composer validate --strictpassedcomposer.lockresolves Collections, Common, Forms, Util, and Validation at 0.10.0No tags or package releases are included in this PR.