Repository navigation
feat(console): add application key generation command - #54
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e5266a3089
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cloning an Assegai project omits its private
.env, and key generation was only available insideassegai new. Addassegai key:generateso users can initializeAPP_SECRET_KEYafter cloning or deliberately rotate it later.Milestone
Next Console 0.10.x maintenance release. This completes the existing project setup workflow while retaining the current 32-byte, hex-encoded key format. Release notes are in
docs/releases/unreleased.mdpending release assignment.What changed
.envfrom.env.exampleand initialize absent, empty, or scaffold-placeholder keys.--forceto replace a real key; support--directoryand non-interactive use..env, detect changes made during confirmation, and never print key material.assegai new, and fail project initialization when the key cannot be created.Scope
Composer install/update hooks do not rotate keys. This writes the local
.env; externally injected secrets stay managed by their deployment environment.Verification
composer validate --strict: passed..envwith a valid key, preserved.env.example, then rejected unattended rotation.Upgrade notes
After upgrading to a release containing this command, run
assegai key:generatein a cloned project. Existing-key rotation can invalidate tokens or encrypted data; restart long-running processes afterward and use the same key across instances of one environment.