perf: isolate layout in Logs virtual viewports - #24
Draft
smiggleworth wants to merge 1 commit into
Draft
smiggleworth wants to merge 1 commit into
smiggleworth wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft checkpoint
Isolate layout in the two existing fixed-height Logs virtual scroll viewports. The necessary synchronous restoration reads remain in place; the proposed containment boundary may let those reads avoid laying out unrelated page content.
Product changes are two app class props and one
contain: layoutdeclaration. There are no package, public API, ref timing, scheduler, cache, state, observer, or performance-budget changes.Evidence already qualified
npm run checkpassed: 53 unit tests, types, lint and build. This command does not include full browser acceptance.Optimization gate and limitations
Native source-bound traces identify getter-triggered style/layout work at the List and Table restoration reads. They establish request sites and observed cost; they do not prove the preceding invalidation owner, the historical failure cause, or any avoided cost from this candidate.
Legibility cost: one named app class shared by two existing roots and one CSS declaration. There is one runtime path. If a browser ignores the declaration, it retains the existing uncontained CSS path; equivalence in such an unsupported browser has not been tested.
Pending before adoption: measured native benefit, full acceptance with the unchanged
<100msmaximum-action and maximum-long-task gates, canonical appearance checks, and complete optimization-gate qualification. Source approval covers this draft checkpoint only.The existing CSS zoom 2 popup positioning defect is independently confirmed on the unchanged baseline and remains unresolved. The normal popup bounds control explicitly resets to zoom 1; containment does not claim to fix zoom 2 overflow.
This PR remains a draft at the user's requested stopping point. No merge, release, or publication is proposed yet.