Repository navigation
refactor(router): separate authoring policy and record registration - #765
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Route authoring now delegates path policy, scope capture, and record registration to three private modules while retaining the public overloads and synchronous definition model. Six reproduced failures are fixed: index/fallback bypassed startup locks and component validation, failed index registration consumed the page slot, and root-page fallback produced
//*.Nested group/page probes assert path composition, layout/page identity, auth and metadata order, denial before loaders, and scope unwinding after thrown definitions. Eleven of fourteen moved helper bodies are unchanged; the three changed bodies contain these fixes. Two architecture checks enforce the dependency direction, including synthetic import/reexport/dynamic-import cases.
Validation on Node 24.21.0:
npm run checkpasses 448 unit, 96 repository, 2,695 jsdom, 158 browser and 12 installed type cases, plus lint/types/build/publint/package artifacts. Formatting and diff checks pass.Ownership and behavior are documented in
docs/internals/route-authoring-ownership.md; changelog and release readiness evidence are updated. Versions remain unchanged.Closes #741.