Repository navigation
refactor(renderer): separate prop lifetimes and value writers - #763
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The host-prop coordinator mixes diff ordering, DOM snapshots, bindings, handlers and refs. Separate orchestration, transactional writers, lifetime ownership and controlled-select settlement into private modules; scalar dispatch uses private class/style/form/HTML writers. All 49 original function bodies are unchanged, including their compiled production DOM-bundle bodies. Existing internal entrypoints and public package contracts stay intact.
The mixed lifetime tests exercise fresh and adopted hosts: a later writer fails after listener/binding/ref replacement is prepared, the old listener and binding remain active, replacement refs do not attach, retry preserves element identity, and replacement/release clean up once. A failed initial adoption separately proves provisional bindings/listeners are discarded and retry installs each lifetime once. All three cases pass on both the original and extracted implementations.
Validation:
npm run check: 433 unit, 92 repository, 2,693 jsdom, 158 browser and 12 installed type cases; formatting, lint, build, public types, publint and package artifact checks pass.Closes #739.