test(ci): add automated test harness and GitHub Actions CI workflow - #26
Merged
Merged
Conversation
ashishsinghbora
commented
Sep 24, 2026
ashishsinghbora
left a comment
ashishsinghbora
left a comment
Owner
Author
There was a problem hiding this comment.
Senior SRE Code Review
Files: tests/test_all.sh, .github/workflows/shellcheck.yml
- test_all.sh Lines 25-35: Self-exclusion logic (
[[ "$(realpath "$script")" == "$SELF" ]]) prevents recursive execution. - test_all.sh Lines 38-45: Validates bash syntax, executable bits, and help flags across all scripts.
- shellcheck.yml: Standard GitHub Actions CI linting and test execution.
Verdict: Approved.
Owner
Author
Review Feedback Addressed & Verified
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
tests/test_all.shregression test suite and.github/workflows/shellcheck.ymlCI workflow.Validation