fix: Filter out empty snapshot directories#765
Merged
zachdaniel merged 1 commit intoMay 27, 2026
Conversation
This fixes an issue where you would not get the prompt to rename a table when there's already a directory with the same name as the *new* table name
Contributor
Author
|
Failing tests are also failing on main it seems. |
Contributor
|
🚀 Thank you for your contribution! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where you would not get the prompt to rename a table when there's already a directory with the same name as the new table name.
I ran into this issue after reverting some resource snapshots using git, which removed the files, but left the (empty) folders in place.
Probably not a super common scenario, but good to have covered imo.
Added a regression test that verifies the behaviour.
Contributor checklist
Leave anything that you believe does not apply unchecked.