Fix failure of calling authenticated APIs when multiple AsgardeoProvider instances are used#334
Open
kavindadimuthu wants to merge 4 commits intoasgardeo:mainfrom
Open
Conversation
6 tasks
…agnization support
kavindadimuthu
force-pushed
the
refactor/singleton-to-multiton
branch
from
09e5dd9 to
db06041
Compare
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. |
Comment on lines
+121
to
-128
| if (!this._instanceID) { | ||
| this._instanceID = 0; | ||
| } else { | ||
| AsgardeoAuthClient._instanceID += 1; | ||
| this._instanceID += 1; | ||
| } | ||
|
|
||
| if (instanceID) { | ||
| AsgardeoAuthClient._instanceID = instanceID; |
Contributor
There was a problem hiding this comment.
We can use the improved logic in the browser package here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces adoption of a Multiton pattern in AsgardeoSPAClient, allowing multiple authentication contexts to coexist within the same application by managing client instances via unique IDs. Several React level APIs have been updated to accept and propagate these instance IDs, ensuring correct isolation and management of authentication state per instance.
Multiton pattern implementation and API updates for instance-awareness::
AsgardeoSPAClientinclient.tsto implement a Multiton pattern, including new static methods for managing instances (getInstance,hasInstance,destroyInstance,getInstanceKeys,destroyAllInstances), and added an instance ID accessor (getInstanceId). [1] [2] [3]AsgardeoReactClientand all organization-related API functions (createOrganization,getAllOrganizations,getMeOrganizations,getOrganization) in React to accept an optionalinstanceIdparameter and use the correct client instance for requests. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]Related Issues
Related PRs
Checklist
Security checks