Skip to content

updates to bring in 21.2.0#144

Merged
briancjewell merged 3 commits intoasfadmin:mainfrom
etcart:ecarton/update-21.2.0
Mar 23, 2026
Merged

updates to bring in 21.2.0#144
briancjewell merged 3 commits intoasfadmin:mainfrom
etcart:ecarton/update-21.2.0

Conversation

@etcart
Copy link
Copy Markdown
Collaborator

@etcart etcart commented Feb 4, 2026

No description provided.

mattp0
mattp0 reviewed Feb 17, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@mattp0 mattp0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good but looks like there is maybe some now deprecated rds variables? Not sure why the tf linter is now upset, but maybe that is why?

@briancjewell
Copy link
Copy Markdown
Contributor

briancjewell commented Mar 17, 2026

What is needed to get this merged/released?

@etcart
Copy link
Copy Markdown
Collaborator Author

etcart commented Mar 19, 2026

hey, sorry I dropped the ball and I'm trying to figure out what to do uh... I don't know what you're talking about unfortunately. the lint step of ci passes, running the same scripts locally also passes across the board. I'm not seeing the deprecated resources issues you're seeing. can you tell me any more about what you're seeing? maybe a flint version issue?

@briancjewell briancjewell requested a review from mattp0 March 23, 2026 17:49
@mattp0
Copy link
Copy Markdown
Contributor

mattp0 commented Mar 23, 2026

hey, sorry I dropped the ball and I'm trying to figure out what to do uh... I don't know what you're talking about unfortunately. the lint step of ci passes, running the same scripts locally also passes across the board. I'm not seeing the deprecated resources issues you're seeing. can you tell me any more about what you're seeing? maybe a flint version issue?

it looks good now, the comment appears to be old!

@briancjewell briancjewell merged commit 9af7e18 into asfadmin:main Mar 23, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattp0 mattp0 mattp0 approved these changes

@mikedorfman mikedorfman Awaiting requested review from mikedorfman

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@etcart @briancjewell @mattp0