Drop a CS0618 pragma that had nothing left to suppress

[Rafael-SOWNet]

Hygiene found while checking what 2.0 still needs.

Sources/Tests/UnitTests/Core/Multithreading/SettingsAndThreads.cs had a region labelled Obsolete settings wrapped in #pragma warning disable CS0618. Neither is true any more:

• SettingClass.As(T value, Action action) (SettingClass.cs:57) is a live, documented, non-obsolete member. It was never removed.
• There are now zero [Obsolete] members anywhere in Sources — Remove every deprecated member for 2.0 (#821) #832 removed all 28.

So the pragma suppressed nothing, while remaining able to hide the next member that becomes obsolete inside those forty lines. This repository has already been bitten once by a CS0618 pragma masking real usage (#832 found two), which is the argument for not leaving dead ones lying about.

The build is the proof, not the reasoning. TreatWarningsAsErrors is on, so with the pragma removed a genuinely obsolete call in that region would now fail the build. It compiles clean, and grep -c CS0618 over Sources is 0.

The label was the more misleading half

The two regions do not divide into "obsolete" and "current". They cover the two ways a setting can be scoped, both supported:

MathS.Settings.MaxExpansionTermCount.As(27, () => { /* ... */ });   // callback form
using var _ = MathS.Settings.MaxExpansionTermCount.Set(27);          // disposable form

A reader would reasonably have concluded from #region Obsolete settings that As was deprecated and avoided it. The regions now name the two forms.

Passed! - Failed: 0, Passed: 10, Skipped: 0, Total: 10 - SettingsAndThreads

🤖 Generated with Claude Code