fix(runtime): timeout wedged snapshot after renderer crash - #22
Draft
cursor[bot] wants to merge 1 commit into
Draft
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
page.content() can hang indefinitely when snapshot runs immediately after a renderer crash (e.g. chrome://crash). Playwright's own timeouts do not fire while CDP is wedged, so companion/MCP callers never return. Add a host-side timeout, page crash tracking, and fail fast on subsequent commands. Co-authored-by: esadrianno <esadrianno@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
After a renderer crash (e.g.
navigatetochrome://crash), an immediatesnapshotcallspage.content()while CDP is wedged. Playwright’s owncontent({ timeout })never settles, so companionPOST /commandsand MCPsnapshothang indefinitely. Other sessions andcreateSessionstill work (distinct from #10).Trigger
POST /sessionsnavigatetochrome://crash→COMMAND_FAILEDquicklysnapshoton the same session → hangs forever on HEADa0fabe3Live Chromium: delay=0 hang reproduced 3/3; delay≥50ms eventually fails with
Target crashed. Companion HTTP abort after 15s confirmed hang;/healthstill OK.Why distinct from #10–#21
createSessionand peer sessions succeed while the crashed session’s snapshot is wedged.Prior hunts misfiled
chrome://crashas a #10 vector; the failure mode is an unbounded snapshot hang, not a deadbrowserPromise.Fix
Promise.racetimeout around snapshot CDP reads (page.content/ aux / title).page.on("crash")+ sessionpageCrashedflag for fail-fast on later commands.Validation
pnpm --filter @webchain/runtime test/test:coverage/typecheckpnpm --filter @webchain/companion test:integration(includes crash→snapshot case, <8s)biome checkon touched files