fix(auth): block PLAYWRIGHT_E2E stub session in production - #54
Draft
cursor[bot] wants to merge 2 commits into
Draft
cursor[bot] wants to merge 2 commits into
cursor[bot] wants to merge 2 commits into
Conversation
Restore the PR #15 double-guard that commit 3244a28 dropped when extracting shouldUseStubAuthSession. PLAYWRIGHT_E2E=1 must not authenticate as the fixed stub user when NODE_ENV=production. Playwright keeps working via NODE_ENV=test + PLAYWRIGHT_E2E=1. Co-authored-by: esadrianno <esadrianno@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This reverts commit d201da7.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restores the production auth guard that commit
3244a28dropped when extractingshouldUseStubAuthSessionfromsrc/auth.ts.Bug
src/lib/auth-mock-session.ts:shouldUseStubAuthSessionNODE_ENV=productionandPLAYWRIGHT_E2E=1(or any accidental env copy from Playwright/E2E). Any caller ofauth()then receives the fixed stub user00000000-0000-0000-0000-000000000001with no credentials.Root cause
PR #15 intentionally required
NODE_ENV !== "production"and a dev/E2E flag. The Turbopack stub extraction kept onlyPLAYWRIGHT_E2E=1 || development, and a unit test locked in the insecure behavior.Fix
falsewhenNODE_ENV === "production".developmentand for Playwright (NODE_ENV=test+PLAYWRIGHT_E2E=1perplaywright.config.ts).Validation
npm run test:run -- tests/lib/auth-mock-session.test.ts— 6 passed.