fix(api): block SSRF in setup test-connection - #52
Draft
cursor[bot] wants to merge 1 commit into
Draft
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Caller-supplied URLs were passed to supabase-js with no host allowlist, so an authenticated POST could probe loopback, private, and metadata addresses. Co-authored-by: esadrianno <esadrianno@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
Authenticated
POST /api/setup/test-connectionpassed the callerurlintocreateClientwith no host allowlist. That server-side fetch could probe loopback, RFC1918, link-local, and cloud-metadata addresses. Failures also echoederror.message, which is a reachability oracle.Trigger: signed-in
POSTwith{"url":"http://169.254.169.254/","key":"x"}(orhttp://127.0.0.1:<port>/).Root cause
The setup wizard trusted the JSON body URL and forwarded it to supabase-js.
Fix
Allow only
httpshosts onsupabase.co/supabase.net, or an exact origin match ofNEXT_PUBLIC_SUPABASE_URL(so local self-hosted Supabase still works when configured). Reject credentials-in-URL. Return a generic 400/500 without exception text.Tests
tests/lib/supabase-connection-url.test.tscovers cloud hosts, blocked private/metadata/DNS-rebinding-style names, and the configured-origin exception.pnpm run test:runpassed (239 tests).