fix(api): prevent stale running patches from clobbering completed executions - #50
Draft
cursor[bot] wants to merge 1 commit into
Draft
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
…cutions Fire-and-forget progress updates from POST /execute could land after the terminal row was written and overwrite status and logs with a running snapshot. Insert the running row first, persist the final snapshot after execute(), and constrain progress UPDATEs to running/pending rows. Co-authored-by: esadrianno <esadrianno@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
Running a multi-node workflow via
POST /api/workflows/[id]/executereturned a completed execution in the HTTP response, but a late fire-and-forget progress patch could overwrite the persisted row withstatus: runningand truncated logs. Refreshing the run history then showed a successful run as still running.Root cause
WorkflowExecutor.notifyUpdatecalledupdateExecutionwithout awaiting it, and the route inserted the row only afterexecute()finished. Mid-run patches that were still in flight after the insert wrotestatus: runningover the completed snapshot. Supabaseupdate()does not error when zero rows match, so this was silent.Fix
execute()so live updates have a targetupdateExecutionof the terminal snapshot afterexecute().in("status", ["running", "pending"])so a late running/paused patch cannot match a completed or failed row{ error }Validation
pnpm exec vitest run tests/lib/execution-store.test.ts(5 passed)pnpm run test:run(240 passed)pnpm exec tsc --noEmit