fix(api): isolate connector credentials by session user - #49
Draft
cursor[bot] wants to merge 1 commit into
Draft
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
The in-memory connectorStore returned every connection (including API keys and OAuth tokens) to any authenticated caller. Scope CRUD and OAuth refresh/callback to session.user.id and ignore client-supplied owner ids. Co-authored-by: esadrianno <esadrianno@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Aug 20, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
Authenticated User A saves an API key / OAuth tokens via
POST /api/connections(or OAuth callback). Authenticated User B on the same Node process callsGET /api/connectionsand receives User A's secrets. Non-owners could also PATCH/DELETE or refresh another user's OAuth tokens.Root cause
connectorStoreis a process-global singleton. Connection CRUD and OAuth refresh looked up connections with noownerUserIdfilter, so any logged-in user saw and mutated every connection.Fix
ownerUserIdonConnectionsession.user.idownerUserIdon create/updateValidation
pnpm exec vitest run tests/lib/connector-store.test.ts tests/api/connections-route.test.ts tests/api/oauth-refresh-route.test.ts(9 passed)pnpm exec tsc --noEmit