fix(builder): block graph mutations during undo/restore PATCH - #45
Draft
cursor[bot] wants to merge 1 commit into
Draft
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Concurrent canvas edits while undo or version restore persists could race the full-graph PATCH and overwrite newer server state with stale graphs. Co-authored-by: esadrianno <esadrianno@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Undo and version restore PATCH the full workflow graph while
isHistoryTransitioningis true, but canvas mutations (delete, connect, paste, etc.) were not gated. A concurrent edit could complete server-side and then be overwritten by the in-flight undo/restore PATCH.Impact
Silent data loss — e.g. delete a node during undo, undo completes and resurrects the deleted node on the server.
Fix
isHistoryTransitioninginto graph mutation and clipboard hooksValidation
npx vitest run tests/components/use-builder-graph-mutations.test.ts