fix(builder): prevent rapid edge deletes from resurrecting connections - #44
Draft
cursor[bot] wants to merge 1 commit into
Draft
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Track optimistic connection state across sequential deletes instead of reading stale React Flow edges from the callback closure. Co-authored-by: esadrianno <esadrianno@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes workflow connection data loss when users delete multiple edges before React re-renders.
Bug and impact
handleEdgesChangecomputed PATCH payloads from a staleedgesclosure, so a second delete could PATCH an older connection set and resurrect edges on the server.Root cause
Sequential edge deletes read React Flow
edgescaptured before state updates flushed.Fix and validation
workflow.connectionsin a ref updated synchronously on each delete.removeConnectionsByIdhelper with unit tests.npm run test:run -- tests/lib/workflow-to-reactflow.test.ts