fix(builder): fetch server graph before version restore undo baseline - #43
Draft
cursor[bot] wants to merge 1 commit into
Draft
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Version restore used the stale SWR workflow snapshot for saveState, so a restore before revalidation could overwrite newer persisted edits and make undo unable to recover them. Fetch the latest workflow from the API first. Co-authored-by: esadrianno <esadrianno@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
Restoring an older workflow version could permanently lose edits that had already persisted to the server. If the user restored before SWR revalidated, the undo baseline was taken from the stale client snapshot instead of the latest server graph.
Root cause
handleRestoreVersioncalledsaveState(previous)withprevious = workflowfrom SWR. The builder disablesrevalidateOnFocus/revalidateOnReconnect, so after a successful mutation the client snapshot can lag behind the server untilmutatecompletes.Fix
resolveLatestPersistedWorkflow()to GET/api/workflows/:idbefore restore.lastPersistedRef.lastPersistedRef/ SWR snapshot if the GET fails.Validation
n2).npm run test:run -- tests/components/builder-canvas.test.tsx— 13/13 passed.