fix(builder): batch multi-select node deletes atomically - #41
Draft
cursor[bot] wants to merge 1 commit into
Draft
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Parallel per-node DELETE requests raced read-modify-write cycles and left some selected nodes behind. Route multi-delete through a single deleteWorkflowNodes update and add API coverage. Co-authored-by: esadrianno <esadrianno@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
Multi-select delete in the workflow builder fired parallel
DELETE /nodes/:idrequests. Each handler does read-modify-write on the workflow graph, so concurrent deletes raced and the last write won — leaving some selected nodes behind after the user deleted multiple nodes at once (silent partial data loss).Root cause
handleNodeDeleteusedPromise.allover per-node DELETE routes introduced in PR #39 review feedback (da21695).deleteWorkflowNodealways reads the full workflow, filters one node, and writes back, so parallel calls overwrite each other.Fix
deleteWorkflowNodesfor a single atomic read-filter-write.DELETE /api/workflows/:id/nodeswith{ nodeIds: string[] }for multi-delete.Validation
pnpm test:run tests/api/workflows.test.ts(18 tests, including new batch delete coverage).