test: cover rate-limit client IP header resolution - #37
Draft
cursor[bot] wants to merge 1 commit into
Draft
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Lock pinned trusted-header preference, comma-split parsing, and anonymous/x-forwarded-for/x-real-ip fallbacks for Upstash client IDs. Co-authored-by: esadrianno <esadrianno@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds unit coverage for
getRateLimitClientId, which resolves the Upstash rate-limit client identifier from trusted vs spoofable headers.Risky behavior now covered
RATE_LIMIT_CLIENT_IP_HEADERwins overx-forwarded-forx-forwarded-for→x-real-ip→anonymousTest files added/updated
tests/lib/rate-limit-client-ip.test.ts(new)Why these tests materially reduce regression risk
Incorrect client-id resolution lets callers bypass or share rate-limit buckets. This is a security-sensitive edge path with no prior unit coverage on main.
How Has This Been Tested?
pnpm exec vitest run tests/lib/rate-limit-client-ip.test.ts(6 passed)