test(registry): fail closed on revoked-list HTTP non-OK - #36
Draft
cursor[bot] wants to merge 1 commit into
Draft
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Cover the HTTP 503 path so marketplace listing cannot leak agents when revocation verification is unavailable. Co-authored-by: esadrianno <esadrianno@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a unit test for the registry fail-closed path when the revoked-agents fetch returns a non-OK HTTP response (e.g. 503), while the registry itself succeeds.
Risky behavior now covered
Test files added/updated
tests/lib/registry.test.tsWhy these tests materially reduce regression risk
Existing coverage handled network rejection and malformed JSON, but not
ok: falseon the revoked list. A regression there could list agents without a verified revocation check.Validation
pnpm exec vitest run tests/lib/registry.test.ts(17 passed)