Repository navigation
fix(desktop): fix Windows ARM64 and Linux release builds - #23
Merged
Merged
Conversation
- Windows ARM64: set PYO3_CROSS_PYTHON_VERSION/IMPLEMENTATION when cross-compiling the x64 locus_rust wheel; PyO3 can't infer the target interpreter's ABI across host architectures. - Linux: install libvulkan1 so linuxdeploy can resolve the bundled Vulkan backend, set NO_STRIP for linuxdeploy's old strip, and build verbosely so an AppImage failure shows its cause.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The first release build after #22 (
v1.0.4.dev88, run 41311698890) passed on Windows x64 and macOS, including their runtime smoke tests, but failed on Windows ARM64 and Linux.Changes
build-runtime.shcross-compiles thelocus_rustwheel for x64. maturin stopped withPYO3_CROSS_PYTHON_VERSION or either an abi3-py3* ... must be specified when cross-compiling. The step now setsPYO3_CROSS_PYTHON_VERSION=3.12andPYO3_CROSS_PYTHON_IMPLEMENTATION=CPython, matching what the app's source mode already uses..deband.rpmbuilt, but the AppImage failed with onlyfailed to run linuxdeploy. This is the first release that bundles Ollama's.solibraries in the AppImage. The change addresses linuxdeploy's two usual failures with such libraries:libvulkan1, so it can resolvelibggml-vulkan.so's dependencyNO_STRIP=true, because its bundledstriprejects libraries built with newer toolchains--verbose, so any remaining failure shows its causeTesting
desktop.ymlparses, and the matrix and env values resolve as expected.