π‘οΈ Sentinel: [HIGH] Fix DOM-based XSS in toast notifications#265
π‘οΈ Sentinel: [HIGH] Fix DOM-based XSS in toast notifications#265arumes31 wants to merge 1 commit into
Conversation
Co-authored-by: arumes31 <114224498+arumes31@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the βοΈ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
β¨ Finishing Touchesπ§ͺ Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
π¨ Severity: HIGH
π‘ Vulnerability: DOM-based Cross-Site Scripting (XSS) in toast notifications.
π― Impact: Untrusted data from the server or user input injected into
showToastvia error messages could result in malicious script execution in the browser.π§ Fix: Replaced
innerHTMLusage withdocument.createElement("span")and safetextContentassignment across all UI template files.β Verification:
go test -short ./...and manual review of code changes.PR created automatically by Jules for task 7702173080154296137 started by @arumes31