π‘οΈ Sentinel: [HIGH] Fix DOM-based XSS in toast notifications#257
π‘οΈ Sentinel: [HIGH] Fix DOM-based XSS in toast notifications#257arumes31 wants to merge 2 commits into
Conversation
Co-authored-by: arumes31 <114224498+arumes31@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the βοΈ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
β¨ Finishing Touchesπ§ͺ Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-authored-by: arumes31 <114224498+arumes31@users.noreply.github.com>
π¨ Severity: HIGH
π‘ Vulnerability: DOM-based Cross-Site Scripting (XSS) via
innerHTMLinjection in theshowToastUI notification component.π― Impact: If an attacker can control the response text of a failed API call (or any message displayed in a toast), they could inject arbitrary HTML and malicious scripts into the administrator's browser context.
π§ Fix: Refactored
showToastacross all templates (admin_management.html,excluded.html,settings.html,whitelist.html) to dynamically create aspanelement and assign the untrustedmessageto itstextContentproperty, thereby safely encoding any HTML before insertion.β Verification: Code review confirms use of
textContent. No test regressions were introduced.PR created automatically by Jules for task 2019052428086464859 started by @arumes31