Skip to content

Remote Shell Swap Bug -> main - #1052

Merged
arul28 merged 2 commits into
mainfrom
ade/remote-shell-swap-bug
Aug 6, 2026
Merged

Remote Shell Swap Bug -> main#1052
arul28 merged 2 commits into
mainfrom
ade/remote-shell-swap-bug

Conversation

@arul28

@arul28 arul28 commented Aug 6, 2026

Copy link
Copy Markdown
Owner

ADE   Open in ADE  ·  ade/remote-shell-swap-bug branch  ·  PR #1052

Summary by CodeRabbit

  • Bug Fixes
    • Cross-machine work lanes now follow the selected sorting mode and manual ordering.
    • Online lanes are prioritized with consistent tie-breaking for predictable results.
    • Reduced unnecessary refreshes when sessions or lanes change.
    • Restored normal foreign-machine polling after the scheduled refresh interval.

@vercel

vercel Bot commented Aug 6, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
ade Ignored Ignored Preview Aug 6, 2026 11:18pm

@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@arul28, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 30 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 279db6c4-1594-47f0-acfc-42dfe63c6c23

📥 Commits

Reviewing files that changed from the base of the PR and between d15ac6a and 58678fa.

📒 Files selected for processing (2)
  • apps/desktop/src/renderer/state/crossMachineLanes.test.ts
  • apps/desktop/src/renderer/state/crossMachineLanes.ts
📝 Walkthrough

Walkthrough

Changes

Cross-machine lane behavior

Layer / File(s) Summary
Work lane ordering integration
apps/desktop/src/renderer/state/crossMachineLanes.ts, apps/desktop/src/renderer/components/terminals/SessionListPane.tsx, apps/desktop/src/renderer/state/crossMachineLanes.test.ts
Cross-machine rows now use Work sort modes and manual lane order. Ordering prioritizes reachable rows and applies deterministic machine/lane tie-breaking.
Foreign refresh cadence
apps/desktop/src/renderer/state/crossMachineLanes.ts, apps/desktop/src/renderer/state/crossMachineLanes.test.ts
Foreign refreshes now separate status and identity requests, preserve polling cadence, track queued work, and reset scheduling state during teardown.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

  • arul28/ADE#977: Both changes update SessionListPane and cross-machine lane ordering.
  • arul28/ADE#711: Both changes address lane lifecycle events and refresh scheduling.
  • arul28/ADE#973: Both changes modify cross-machine Work sidebar and session-lane behavior.

Suggested labels: desktop, docs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title identifies the remote shell swap bug fix, which matches the pull request objective and the cross-machine lane changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ade/remote-shell-swap-bug

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@apps/desktop/src/renderer/state/crossMachineLanes.ts`:
- Around line 383-394: The foreign lane ordering input uses a non-unique bare
lane ID, preventing composite manual-order entries from matching across
machines. In apps/desktop/src/renderer/state/crossMachineLanes.ts lines 383-394,
update crossMachineLaneOrderInput to use the composite machine-and-lane ID. In
apps/desktop/src/renderer/state/crossMachineLanes.test.ts lines 177-216, add a
named regression test with two machines sharing a lane ID and verify composite
manualOrder determines their order.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: b67eb1b6-22c4-41c8-827d-5052f48dfe1c

📥 Commits

Reviewing files that changed from the base of the PR and between 5d725b0 and d15ac6a.

⛔ Files ignored due to path filters (1)
  • docs/features/terminals-and-sessions/README.md is excluded by !docs/**
📒 Files selected for processing (3)
  • apps/desktop/src/renderer/components/terminals/SessionListPane.tsx
  • apps/desktop/src/renderer/state/crossMachineLanes.test.ts
  • apps/desktop/src/renderer/state/crossMachineLanes.ts

Comment thread apps/desktop/src/renderer/state/crossMachineLanes.ts
@arul28

arul28 commented Aug 6, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@arul28
arul28 merged commit 0e53ea9 into main Aug 6, 2026
68 checks passed
@arul28
arul28 deleted the ade/remote-shell-swap-bug branch August 6, 2026 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant