Start Skill Am Gonna List -> Primary - #1049
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (42)
Disabled knowledge base sources:
📝 WalkthroughWalkthroughThe PR updates orchestration prompts and provider isolation, improves Claude task cleanup, adds background-job grouping and notice deduplication, and revises ADE skill guidance. It also removes the bundled ChangesOrchestration and chat behavior
Estimated code review effort: 5 (Critical) | ~120 minutes Possibly related PRs
Suggested labels: ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning Tools execution failed with the following error: Failed to run tools: 14 UNAVAILABLE: read ECONNRESET Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ADE hosts harnesses; it does not replace them. Every provider already ships its own operating instructions, so ADE's bundled skills adding a second layer of "how to think" competes with the harness the user chose. Strip generic workflow guidance from the bundled skills and keep only what is true and ADE-specific: what a command does, what it returns, and the facts an agent cannot infer from the repo. Destructive-operation notes stay, restated as facts about consequences rather than instructions about conduct. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
An orchestrator lead may run on any provider the user picks, but only Claude's native tool names were denied. A Codex, Cursor, Droid, or OpenCode lead kept full edit and shell access while holding danger-full-access with approvals set to never, so the "leads never touch files" rule held on exactly one runtime. Add provider-native deny lists in orchestrationRuntimePolicy and apply them at each runtime's own gate: Cursor loses the setting layers that carry writable tools and MCP servers, OpenCode gets only ADE's managed lease, and Droid's protocol denies its editing tools. MCP calls on a gated lead fail closed. Known gap: OpenCode project-level config is not yet isolated. The MCP map ADE hands it is gated, but a project config it reads on its own is not. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Background job rows and plan-limit notices each rendered once per emission, so a turn that spawned several waiters or crossed the usage threshold more than once filled the transcript with near-identical cards. Fold consecutive background rows into a single card and show the usage notice at most once per turn. Both stay in the thread; only the repetition goes. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
arul28
force-pushed
the
ade/orchestrator-lead-tool-gate
branch
from
August 6, 2026 17:08
1ea7188 to
10bb314
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit