Fix warnings in EAD XML exports#2315
Merged
anvit merged 2 commits intoartefactual:qa/2.xfrom Apr 15, 2026
Merged
Conversation
sarah-mason
added
the
Community
melaniekung
approved these changes
Mar 30, 2026
Contributor
melaniekung
left a comment
melaniekung
left a comment
There was a problem hiding this comment.
LGTM, thanks @danloveg !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2269
Adds two variables referenced in XML templates and coalesces null strings to
''instrlen()calls to fix large amount of warnings when running XML exports.I didn't fix the warning mentioned in the issue in
BaseEvent.model.phpbecause that felt like a separate issue. I think #1957 might be a better issue to address that since thestrlen()call in that example sits within acall_user_func_array. I can address that in this pull request though if needed.