Open
Conversation
Member
sbreker
commented
Feb 2, 2026
sbreker
commented
- Remove per-row dot output. renderProgressDescription() now writes a single update line to STDERR every ~5s.
- Print a final summary to STDOUT.
sbreker
force-pushed
the
dev/cli-import-export-status
branch
3 times, most recently
from
c24794a to
b062a02
Compare
sbreker
force-pushed
the
dev/cli-import-export-status
branch
2 times, most recently
from
7eb21eb to
a9e11fe
Compare
- Remove per-row dot output. renderProgressDescription() now writes a single update line to STDERR every ~5s. - Print a final summary to STDOUT.
sbreker
force-pushed
the
dev/cli-import-export-status
branch
from
a9e11fe to
df03843
Compare
anvit
reviewed
Mar 2, 2026
| $this->log("\nImported ".$count.' XML/CSV files in '.$timer->elapsed().' s. '.memory_get_peak_usage().' bytes used.'); | ||
| if (!empty($options['verbose'])) { | ||
| $elapsed = $timer->elapsed(); | ||
| $peakMb = round(memory_get_peak_usage() / 1048576, 2); |
Contributor
There was a problem hiding this comment.
Can we use a constant instead 1048576? Or use 1024 * 1024 for easier comprehension and consistency like QubitFlatFileImport does?
Contributor
|
Also wanted to note that the docs will need some updates. I noticed at a quick glance that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.