Skip to content

kernel: fix C23 build errors for libbpf in D1 - #10773

Open
khaliforce wants to merge 1 commit into
armbian:mainfrom
khaliforce:fix-c23-kernel
Open

khaliforce wants to merge 1 commit into
armbian:mainfrom
khaliforce:fix-c23-kernel

Conversation

@khaliforce

@khaliforce khaliforce commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

This PR fixes compilation errors on GCC 15 / C23 standard where strchr returns a const pointer, causing a discarded qualifier error in libbpf.

Summary by CodeRabbit

  • Bug Fixes
    • Improved internal handling of read-only search path data in the eBPF library.
    • No user-visible behavior changes are expected.

@coderabbitai

coderabbitai Bot commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: armbian/build/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: e867e31e-d62a-4974-8c90-58360e45fa19

📥 Commits

Reviewing files that changed from the base of the PR and between faa8a66 and 132a61e.

📒 Files selected for processing (1)
  • patch/kernel/d1-edge/0001-fix-libbpf-const-strchr.patch

Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review.


📝 Walkthrough

Walkthrough

The patch changes the local next_path declaration in tools/lib/bpf/libbpf.c from char * to const char *. Search-path iteration logic remains unchanged.

Changes

libbpf const qualifier adjustment

Layer / File(s) Summary
Search-path pointer declaration
patch/kernel/d1-edge/0001-fix-libbpf-const-strchr.patch
The patch changes the local next_path variable to const char * in the search-path iteration loop. No other logic changes.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: fixing C23 build errors in libbpf for D1 kernels.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added 11 Milestone: Fourth quarter release size/small PR with less then 50 lines Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... labels Sep 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

11 Milestone: Fourth quarter release Hardware Hardware related like kernel, U-Boot, ... Needs review Seeking for review Patches Patches related to kernel, U-Boot, ... size/small PR with less then 50 lines

Development

Successfully merging this pull request may close these issues.

1 participant