gl-mt2500-v2: stop shipping Airoha firmware in the BSP - #10686
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe GL-MT2500 v2 board configuration no longer downloads EN8811H firmware blobs. It retains license retrieval and relies on the ChangesAiroha firmware packaging
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The change resolves the package ownership conflict without leaving an identified firmware packaging or initramfs regression. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
6940d63 to
f71291b
Compare
armbian-firmware has carried airoha/EthMD32.{dm,DSP}.bin since armbian/firmware
2a9e1c19 ("airoha: add EN8811H 2.5G PHY firmware", 2026-09-10). This board
config has been downloading the same two files into the bsp-cli package since it
was added on 2026-09-04, so from the 10th onwards two packages claimed the same
paths and dpkg refused the unpack:
dpkg: error processing archive armbian-bsp-cli-gl-mt2500-v2-edge...deb (--unpack):
trying to overwrite '/lib/firmware/airoha/EthMD32.dm.bin',
which is also in package armbian-firmware (26.11.0-trunk.44)
Every Gl-mt2500-v2 image build has failed there since.
Drop the download hook entirely -- firmware and licence both. armbian-firmware
provides the firmware now, and the licence belongs with whoever ships the blobs
rather than with a board package that no longer does. That also drops this
board's build-time dependency on a GitLab API endpoint.
The initramfs hook is unchanged and still pulls both files in, just from
armbian-firmware instead of from this package.
gl-mt2500-v2 is the only board config that shipped airoha firmware, so nothing
else needs the same treatment.
Signed-off-by: Igor Pecovnik <igor@armbian.com>
f71291b to
105613b
Compare
What is broken
Every
Gl-mt2500-v2image build fails when dpkg unpacks the BSP:Seen in armbian/ci run 34548029496 (
Gl-mt2500-v2_trixie_edge_6.16.y_minimal).Why
Two packages started claiming the same paths, six days apart:
airoha/EthMD32.{dm,DSP}.bininto the bsp-cli package2a9e1c19— "airoha: add EN8811H 2.5G PHY firmware" — adds the same two files toarmbian-firmwarearmbian-firmwareis installed first, so the BSP unpack is the one that dies. dpkg will not let two packages own a path, and neither declares aReplaces:.Nothing was wrong with the board config when it was written — the firmware simply moved into the shared package six days later.
Fix
Drop the whole download hook: both the firmware and the licence text.
armbian-firmwareprovides the firmware now.curlfetches plus sha256 checks that had to be kept in step with an external repo).The initramfs hook is unchanged and still does
add_firmware "airoha/EthMD32.dm.bin"/.DSP.bin; those files now come fromarmbian-firmware, which is installed before the BSP, so the hook still resolves them.Net: 8 insertions, 30 deletions.
gl-mt2500-v2is the only board config that shipped airoha firmware (grep -rln airoha config/boards/), so nothing else needs the same treatment.Two follow-ups, deliberately not in here
armbian/firmwareships the EN8811H blobs without aLICENSE.airoha(it is not in that repo'sLICENSES/). Since this board package no longer carries it either, the licence text is now absent from images. Adding it to armbian/firmware alongside the blobs would be the right home.add_firmwarewithout|| true, whereas board: add Banana Pi R3 Mini #10678 (BPi R3 Mini) uses|| truefor the same two files. Now that the firmware comes from a separate package, a system withoutarmbian-firmwarewould failupdate-initramfson every kernel upgrade rather than warn. Worth aligning.Signed-off-by: Igor Pecovnik igor@armbian.com