action: version nightly builds from the latest trunk tag (not stable+1) - #10496
igorpecovnik wants to merge 1 commit into
Conversation
The base-version resolver matched only clean MAJOR.MINOR.PATCH tags from armbian/ci and then incremented the patch. On a build from main that meant the current stable (e.g. 26.8.3) + 1 = 26.8.4, even though ci's live development series was already 26.11.0-trunk.N - so SDK/nightly images and their armbian-images.json were stamped with a stale, wrong version. Include the X.Y.Z-trunk.N nightly tags in the candidate set and take the highest across both with sort -V. When the winner is a trunk tag, reuse it verbatim (it already denotes the current unreleased dev version - no +1); a clean stable tag still gets the next-patch bump as before. Signed-off-by: Igor Pecovnik <igor@armbian.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe composite action now resolves the highest stable or trunk release tag. It preserves trunk versions as-is and increments stable versions after removing release-candidate or metadata suffixes. ChangesVersion resolution
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to The PR makes a localized version-selection change, and no actionable merge-blocking risk remains based on the supplied evidence; it is merge-ready after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Problem
The build action's base-version resolver only matched clean
MAJOR.MINOR.PATCHtags fromarmbian/ciand then +1'd the patch:So a build from
mainpicked the latest stable (26.8.3) and produced26.8.4— even thougharmbian/ci's live development series was already26.11.0-trunk.20. The SDK's images and itsarmbian-images.jsonweretherefore stamped with a stale, wrong version (
26.8.4).Fix
Include the
X.Y.Z-trunk.Nnightly tags in the candidate set and take thehighest across both with
sort -V:26.11.0-trunk.20); italready denotes the current unreleased dev version, so no
+1.Verified
26.11.0-trunk.20(+26.8.3stable)26.8.4❌26.11.0-trunk.20✅26.8.3(no trunk)26.8.426.8.4(unchanged)v26.8.3v26.8.4v26.8.4(unchanged)sort -Vover the real tag set selects26.11.0-trunk.20. The frameworkalready supports a
-trunk.NREVISION (that's how ci's own nightlies areversioned), so filenames/manifests parse it fine.
Pairs with the SDK ISO/manifest work (#10495, armbian/sdk#40).
Summary by CodeRabbit
New Features
-trunk.Nrelease versions.Bug Fixes