Skip to content

Add git.u-boot-project.org to GitLab rules, mirrors - #10477

Open
vidplace7 wants to merge 1 commit into
armbian:mainfrom
vidplace7:git-trust-uboot
Open

vidplace7 wants to merge 1 commit into
armbian:mainfrom
vidplace7:git-trust-uboot

Conversation

@vidplace7

@vidplace7 vidplace7 commented Aug 19, 2026

Copy link
Copy Markdown
Member

Description

Uboot development has moved (at least in part) from https://source.denx.de/ (unreliable/often-down) to https://git.u-boot-project.org/

Add the new URL to the list of GitLab servers and the uboot mirror list, so that it can be used in Armbian packaging.

How Has This Been Tested?

Tested changing origin from source.denx.de to git.u-boot-project.org for rockchip kwiboo.
GitLab makefile resolution is functional after this change.

Checklist:

  • I have performed a self-review of my own code

Summary by CodeRabbit

  • New Features

    • Added support for the official U-Boot Project repository as a U-Boot mirror option.
    • Improved retrieval of Makefiles from the U-Boot Project Git repository.
  • Bug Fixes

    • Corrected repository URL handling to ensure Makefiles are fetched successfully from U-Boot Project sources.

Uboot development has moved (at least in part) from https://source.denx.de/ to https://git.u-boot-project.org/

Add the new URL to the list of GitLab servers and uboot mirrors, so that it can be used in Armbian packaging.
@github-actions github-actions Bot added 08 Milestone: Third quarter release size/small PR with less then 50 lines labels Aug 19, 2026
@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: abe8788b-1549-4186-87ba-91b24cf4be13

📥 Commits

Reviewing files that changed from the base of the PR and between 9de7be0 and 2adfd5f.

📒 Files selected for processing (2)
  • lib/functions/configuration/main-config.sh
  • lib/functions/general/git-ref2info.sh

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The build configuration adds u-boot-project as a supported U-Boot mirror. Makefile retrieval now recognizes the U-Boot Project Git URL and uses the existing raw-file URL format.

Changes

U-Boot Project mirror

Layer / File(s) Summary
U-Boot Project mirror configuration and retrieval
lib/functions/configuration/main-config.sh, lib/functions/general/git-ref2info.sh
The u-boot-project mirror selects the official U-Boot Project repository. Its Git URL uses the existing GitLab-compatible Makefile retrieval path.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 2adfd

This localized change adds the new U-Boot GitLab host and mirror URL without any identified merge-blocking risk; it is merge-ready after normal checks and review.

Possibly related PRs

  • armbian/build#10066: Both changes extend Git source URL handling in obtain_makefile_body_from_git().
  • armbian/build#10250: This change adds mainline U-Boot mirror support related to the mainline U-Boot enablement.

Suggested reviewers: iav, igorpecovnik

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change by identifying the new git.u-boot-project.org GitLab rule and mirror support.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added Needs review Seeking for review Framework Framework components labels Aug 19, 2026
@igorpecovnik

Copy link
Copy Markdown
Member

Wouldn't be better to switch then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

08 Milestone: Third quarter release Framework Framework components Needs review Seeking for review size/small PR with less then 50 lines

Development

Successfully merging this pull request may close these issues.

2 participants