Conversation
JPyke3
requested changes
Sep 18, 2026
Member
There was a problem hiding this comment.
Super solid work, implementation looks all good!
Some minor workflow fixes.
workflow_dispatch:probably will never work because if some if conditions- I suspect the cache is maybe not hitting correctly? Could be totally wrong as I only really referenced the GH docs.
Happy for you close the comments if you don't think applicable
|
|
||
| jobs: | ||
| validate: | ||
| if: github.event_name == 'pull_request' |
Member
There was a problem hiding this comment.
Suggested change
| if: github.event_name == 'pull_request' || github.event_name == 'workflow_dispatch' |
| run: mkdocs build --strict | ||
|
|
||
| deploy: | ||
| if: github.event_name == 'push' |
Member
There was a problem hiding this comment.
Suggested change
| if: github.event_name == 'push' || github.event_name == 'workflow_dispatch' |
Comment on lines
+39
to
+42
| uses: actions/cache@v4 | ||
| with: | ||
| path: .armada-release-tag | ||
| key: armada-release-tag |
Member
There was a problem hiding this comment.
Suggested change
| uses: actions/cache@v4 | |
| with: | |
| path: .armada-release-tag | |
| key: armada-release-tag | |
| uses: actions/cache@v4 | |
| with: | |
| path: .armada-release-tag | |
| key: armada-release-tag-${{ steps.latest.outputs.latest }} |
Member
There was a problem hiding this comment.
Looks like GHs doco says:
You cannot change the contents of an existing cache. Instead, you can create a new cache with a new key.
Not sure if you've tested this one but I suspect the cache may never update without a unique key.
This is what I'd do to do this but you'll need to update the conditions down the line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a Downloads page that is generated from the Armada release feed. The page content is created via a mkdocs hook, and transforms the release markdown into something that renders nicely in mkdocs.
I've also added a workflow that fires every 30 minutes to check for new releases. It will cache the last release version found and only trigger the build if changed. Happy to adjust or remove that if we feel it's unnecessary. Just didn't want us to have to manually trigger a site build when we release, though we could easily do that with our release cadence right now.