Fix hardcoded workstation paths in test/51_composition and test/52_sequence - #23
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22.
What
Two one-line changes:
test/51_composition.lispandtest/52_sequence.lisploaded sources via hardcoded absolute paths (/srv/langs/nolang/...— the author's workstation). Switched to the portable(merge-pathnames "../src/..." *load-pathname*)convention the rest of the battery already uses.Why it matters
The tests passed only on machines where the clone happens to live at
/srv/langs/nolang. In any other clone they die withSB-INT:SIMPLE-FILE-ERROR— which the CI workflow's first run (#21) immediately demonstrated:УПАЛО: 2on a green-elsewhere battery. This is the exact portability class the repo already knows fromnolang-shell.sh(removed in #19).Proof
Both tests green locally after the fix (
RC=0, their pass markers printed). Full proof lands when #21's run goes green on the rebased CI branch — this fix is its blocking dependency.What this does NOT prove
repl.lisp, which has the same disease in three places (lines 30, 108, 110) but lives outside the battery — tracked in test/51_composition and test/52_sequence hardcode /srv/langs/nolang — battery not portable (caught by CI on first run) #22 as follow-up.